KazukyAkayashi/m3_lightmeter
KazukyAkayashi/m3_lightmeter
1
0
Fork 0
mirror of https://github.com/vodemn/m3_lightmeter.git synced 2025-09-05 11:56:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

ML-240 Animated picker jumps off-screen after values list changes (#270)

Browse source 
* check for negative offset

* catch late init error
This commit is contained in:
Vadim 2025-08-29 10:55:03 +02:00 committed by GitHub
parent 49d0a2175f
commit 872f279637
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
lib/screens/metering/components/shared/readings_container/components/shared/animated_dialog_picker/components/animated_dialog/widget_dialog_animated.dart
View file

@ -29,8 +29,6 @@ class AnimatedDialog extends StatefulWidget {
} }
class AnimatedDialogState extends State<AnimatedDialog> with SingleTickerProviderStateMixin { class AnimatedDialogState extends State<AnimatedDialog> with SingleTickerProviderStateMixin {
final GlobalKey _key = GlobalKey();
late Size _closedSize; late Size _closedSize;
late Offset _closedOffset; late Offset _closedOffset;
@ -129,7 +127,6 @@ class AnimatedDialogState extends State<AnimatedDialog> with SingleTickerProvide
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
return GestureDetector( return GestureDetector(
key: _key,
onTap: _openDialog, onTap: _openDialog,
child: Opacity( child: Opacity(
opacity: _isDialogShown ? 0 : 1, opacity: _isDialogShown ? 0 : 1,
@ -140,13 +137,13 @@ class AnimatedDialogState extends State<AnimatedDialog> with SingleTickerProvide
void _setClosedOffset() { void _setClosedOffset() {
WidgetsBinding.instance.addPostFrameCallback((_) { WidgetsBinding.instance.addPostFrameCallback((_) {
final renderBox = _key.currentContext?.findRenderObject()! as RenderBox?; final renderBox = context.findRenderObject()! as RenderBox?;
if (renderBox != null) { if (renderBox != null) {
final size = MediaQuery.sizeOf(context); final size = MediaQuery.sizeOf(context);
final padding = MediaQuery.paddingOf(context); final padding = MediaQuery.paddingOf(context);
final maxWidth = size.width - padding.horizontal - Dimens.dialogMargin.horizontal; final maxWidth = size.width - padding.horizontal - Dimens.dialogMargin.horizontal;
final maxHeight = size.height - padding.vertical - Dimens.dialogMargin.vertical; final maxHeight = size.height - padding.vertical - Dimens.dialogMargin.vertical;
_closedSize = _key.currentContext!.size!; _closedSize = context.size!;
_sizeTween = SizeTween( _sizeTween = SizeTween(
begin: _closedSize, begin: _closedSize,
end: Size( end: Size(
@ -156,7 +153,16 @@ class AnimatedDialogState extends State<AnimatedDialog> with SingleTickerProvide
); );
_sizeAnimation = _sizeTween.animate(_defaultCurvedAnimation); _sizeAnimation = _sizeTween.animate(_defaultCurvedAnimation);
_closedOffset = renderBox.localToGlobal(Offset.zero); final globalOffset = renderBox.localToGlobal(Offset.zero);
try {
_closedOffset = Offset(
//TODO: when updating layout or changing one of selected picker values, X offset is negative for some reason
globalOffset.dx > 0 ? globalOffset.dx : _closedOffset.dx,
globalOffset.dy,
);
} catch (_) {
_closedOffset = globalOffset;
}
_offsetAnimation = SizeTween( _offsetAnimation = SizeTween(
begin: Size( begin: Size(
_closedOffset.dx + _closedSize.width / 2, _closedOffset.dx + _closedSize.width / 2,