dart fixes

analysis_options.yaml

@@ -1 +1,5 @@
 include: package:lint/strict.yaml
+
+analyzer:
+  exclude:
+    - "**/generated/**"

lib/application.dart

@@ -32,7 +32,7 @@ class Application extends StatelessWidget {
     return FutureBuilder(
       future: Future.wait([
         SharedPreferences.getInstance(),
-        Platform.isAndroid ? const LightSensorService().hasSensor() : Future.value(false),
+        if (Platform.isAndroid) const LightSensorService().hasSensor() else Future.value(false),
       ]),
       builder: (_, snapshot) {
         if (snapshot.data != null) {
@@ -40,7 +40,7 @@ class Application extends StatelessWidget {
             providers: [
               Provider.value(value: env.copyWith(hasLightSensor: snapshot.data![1] as bool)),
               Provider(
-                  create: (_) => UserPreferencesService(snapshot.data![0] as SharedPreferences)),
+                  create: (_) => UserPreferencesService(snapshot.data![0] as SharedPreferences),),
               Provider(create: (_) => const CaffeineService()),
               Provider(create: (_) => const HapticsService()),
               Provider(create: (_) => PermissionsService()),

lib/data/models/exposure_pair.dart

@@ -7,5 +7,5 @@ class ExposurePair {
   const ExposurePair(this.aperture, this.shutterSpeed);
 
   @override
-  String toString() => '${aperture.toString()} - ${shutterSpeed.toString()}';
+  String toString() => '$aperture - $shutterSpeed';
 }

lib/data/models/metering_screen_layout_config.dart

@@ -4,7 +4,7 @@ typedef MeteringScreenLayoutConfig = Map<MeteringScreenLayoutFeature, bool>;
 
 extension MeteringScreenLayoutConfigJson on MeteringScreenLayoutConfig {
   static MeteringScreenLayoutConfig fromJson(Map<String, dynamic> data) => data.map(
-      (key, value) => MapEntry(MeteringScreenLayoutFeature.values[int.parse(key)], value as bool));
+      (key, value) => MapEntry(MeteringScreenLayoutFeature.values[int.parse(key)], value as bool),);
 
   Map<String, dynamic> toJson() => map((key, value) => MapEntry(key.index.toString(), value));
 }

lib/data/shared_prefs_service.dart

@@ -86,7 +86,9 @@ class UserPreferencesService {
   MeteringScreenLayoutConfig get meteringScreenLayout {
     final configJson = _sharedPreferences.getString(_meteringScreenLayoutKey);
     if (configJson != null) {
-      return MeteringScreenLayoutConfigJson.fromJson(json.decode(configJson));
+      return MeteringScreenLayoutConfigJson.fromJson(
+        json.decode(configJson) as Map<String, dynamic>,
+      );
     } else {
       return {
         MeteringScreenLayoutFeature.extremeExposurePairs: true,

lib/interactors/metering_interactor.dart

@@ -58,8 +58,6 @@ class MeteringInteractor {
     AppSettings.openAppSettings();
   }
 
-  void enableHaptics(bool enable) => _userPreferencesService.haptics = enable;
-
   Future<bool> hasAmbientLightSensor() async {
     if (Platform.isAndroid) {
       return _lightSensorService.hasSensor();

lib/providers/equipment_profile_provider.dart

@@ -72,7 +72,7 @@ class EquipmentProfileProviderState extends State<EquipmentProfileProvider> {
       ndValues: NdValue.values,
       shutterSpeedValues: ShutterSpeedValue.values,
       isoValues: IsoValue.values,
-    ));
+    ),);
     _refreshSavedProfiles();
   }
 

lib/screens/metering/bloc_metering.dart

@@ -158,12 +158,12 @@ class MeteringBloc extends Bloc<MeteringEvent, MeteringState> {
             iso: _iso,
             nd: _nd,
             exposurePairs: _buildExposureValues(ev),
-          ));
+          ),);
   }
 
   List<ExposurePair> _buildExposureValues(double ev) {
     if (ev.isNaN || ev.isInfinite) {
-      return List.empty(growable: false);
+      return List.empty();
     }
 
     /// Depending on the `stopType` the exposure pairs list length is multiplied by 1,2 or 3
@@ -200,11 +200,11 @@ class MeteringBloc extends Bloc<MeteringEvent, MeteringState> {
     }
 
     final int itemsCount = min(_apertureValues.length + shutterSpeedOffset,
-            _shutterSpeedValues.length + apertureOffset) -
+            _shutterSpeedValues.length + apertureOffset,) -
         max(apertureOffset, shutterSpeedOffset);
 
     if (itemsCount < 0) {
-      return List.empty(growable: false);
+      return List.empty();
     }
     return List.generate(
       itemsCount,

lib/screens/metering/components/bottom_controls/components/measure_button/widget_button_measure.dart

@@ -73,7 +73,6 @@ class _MeteringMeasureButtonState extends State<MeteringMeasureButton> {
                   /// This key is needed to make indicator start from the same point every time
                   key: ValueKey(widget.isMetering),
                   color: Theme.of(context).colorScheme.onSurface,
-                  strokeWidth: Dimens.grid4,
                   value: widget.isMetering ? null : 1,
                 ),
               ),

lib/screens/metering/components/bottom_controls/widget_bottom_controls.dart

@@ -43,7 +43,7 @@ class MeteringBottomControls extends StatelessWidget {
                         onPressed: onSwitchEvSourceType,
                         icon: Icon(context.watch<EvSourceType>() != EvSourceType.camera
                             ? Icons.camera_rear
-                            : Icons.wb_incandescent),
+                            : Icons.wb_incandescent,),
                       ),
                     ),
                   )

lib/screens/metering/components/camera_container/bloc_container_camera.dart

@@ -167,7 +167,7 @@ class CameraContainerBloc extends EvSourceBlocBase<CameraContainerEvent, CameraC
       exposureOffsetRange: _exposureOffsetRange!,
       exposureOffsetStep: _exposureStep,
       currentExposureOffset: _currentExposureOffset,
-    ));
+    ),);
   }
 
   Future<double?> _takePhoto() async {

lib/screens/metering/components/camera_container/components/camera_view/widget_camera_view.dart

@@ -5,7 +5,7 @@ import 'package:flutter/services.dart';
 class CameraView extends StatelessWidget {
   final CameraController controller;
 
-  const CameraView({required this.controller, Key? key}) : super(key: key);
+  const CameraView({required this.controller, super.key});
 
   @override
   Widget build(BuildContext context) {

lib/screens/metering/components/camera_container/widget_container_camera.dart

@@ -103,7 +103,7 @@ class CameraContainer extends StatelessWidget {
 }
 
 class _CameraViewBuilder extends StatelessWidget {
-  const _CameraViewBuilder({Key? key}) : super(key: key);
+  const _CameraViewBuilder();
 
   @override
   Widget build(BuildContext context) {
@@ -156,7 +156,7 @@ class _CameraControlsBuilder extends StatelessWidget {
                 context.read<CameraContainerBloc>().add(
                     state.error == CameraErrorType.permissionNotGranted
                         ? const OpenAppSettingsEvent()
-                        : const InitializeEvent());
+                        : const InitializeEvent(),);
               },
             );
           } else {

lib/screens/metering/components/shared/metering_top_bar/shape_top_bar_metering.dart

@@ -59,7 +59,6 @@ class MeteringTopBarShape extends CustomPainter {
       path.arcToPoint(
         Offset(appendixWidth, size.height + appendixHeight + allowedRadius),
         radius: circularRadius,
-        clockwise: true,
       );
       path.lineTo(appendixWidth, size.height - allowedRadius);
       path.arcToPoint(
@@ -98,7 +97,6 @@ class MeteringTopBarShape extends CustomPainter {
         Offset(allowedRadius, -allowedRadius),
         radius: Radius.circular(allowedRadius),
         rotation: 90,
-        clockwise: true,
       );
 
       // Right side with bottom corner

lib/screens/metering/components/shared/readings_container/components/animated_dialog_picker/components/animated_dialog/widget_dialog_animated.dart

@@ -71,7 +71,7 @@ class AnimatedDialogState extends State<AnimatedDialog> with SingleTickerProvide
         0.8,
         curve: Curves.ease,
       ),
-    ));
+    ),);
     _openedOpacityAnimation = Tween<double>(
       begin: 0,
       end: 1,
@@ -82,7 +82,7 @@ class AnimatedDialogState extends State<AnimatedDialog> with SingleTickerProvide
         1.0,
         curve: Curves.easeInOut,
       ),
-    ));
+    ),);
 
     WidgetsBinding.instance.addPostFrameCallback((_) {
       final mediaQuery = MediaQuery.of(context);

lib/screens/metering/components/shared/readings_container/components/animated_dialog_picker/components/dialog_picker/widget_picker_dialog.dart

@@ -110,7 +110,6 @@ class _DialogPickerState<T> extends State<DialogPicker<T>> {
           padding: Dimens.dialogActionsPadding,
           child: Row(
             crossAxisAlignment: CrossAxisAlignment.end,
-            mainAxisSize: MainAxisSize.max,
             children: [
               const Spacer(),
               TextButton(

lib/screens/metering/components/shared/readings_container/components/reading_value_container/widget_container_reading_value.dart

@@ -42,7 +42,6 @@ class ReadingValueContainer extends StatelessWidget {
           padding: const EdgeInsets.all(Dimens.paddingM),
           child: Column(
             crossAxisAlignment: CrossAxisAlignment.start,
-            mainAxisAlignment: MainAxisAlignment.start,
             mainAxisSize: MainAxisSize.min,
             children: _items,
           ),

lib/screens/settings/components/metering/components/calibration/components/calibration_dialog/bloc_dialog_calibration.dart

@@ -36,7 +36,7 @@ class CalibrationDialogBloc extends Bloc<CalibrationDialogEvent, CalibrationDial
   }
 
   void _onLightSensorEvCalibrationChanged(
-      LightSensorEvCalibrationChangedEvent event, Emitter emit) {
+      LightSensorEvCalibrationChangedEvent event, Emitter emit,) {
     _lightSensorEvCalibration = event.value;
     emit(CalibrationDialogState(_cameraEvCalibration, _lightSensorEvCalibration));
   }

lib/screens/settings/components/metering/components/equipment_profiles/components/equipment_profile_screen/components/equipment_profile_container/components/equipment_list_tiles/components/dialog_range_picker/widget_dialog_picker_range.dart

@@ -64,7 +64,6 @@ class _DialogRangePickerState<T extends PhotographyValue> extends State<DialogRa
                     _start.toDouble(),
                     _end.toDouble(),
                   ),
-                  min: 0,
                   max: widget.values.length.toDouble() - 1,
                   divisions: widget.values.length - 1,
                   onChanged: (value) {

lib/screens/settings/components/metering/components/equipment_profiles/components/equipment_profile_screen/components/equipment_profile_container/widget_container_equipment_profile.dart

@@ -72,7 +72,6 @@ class EquipmentProfileContainerState extends State<EquipmentProfileContainer>
           children: [
             ListTile(
               title: Row(
-                mainAxisAlignment: MainAxisAlignment.start,
                 children: [
                   _AnimatedNameLeading(controller: _controller),
                   const SizedBox(width: Dimens.grid8),

lib/screens/settings/components/metering/components/equipment_profiles/widget_list_tile_equipment_profiles.dart

@@ -13,7 +13,7 @@ class EquipmentProfilesListTile extends StatelessWidget {
       title: Text(S.of(context).equipmentProfiles),
       onTap: () {
         Navigator.of(context).push<EquipmentProfileData>(
-            MaterialPageRoute(builder: (_) => const EquipmentProfilesScreen()));
+            MaterialPageRoute(builder: (_) => const EquipmentProfilesScreen()),);
       },
     );
   }

lib/screens/settings/components/theme/components/primary_color/components/primary_color_picker_dialog/widget_dialog_picker_primary_color.dart

@@ -68,7 +68,7 @@ class _PrimaryColorDialogPickerState extends State<PrimaryColorDialogPicker> {
                 ],
               ),
             ],
-          )),
+          ),),
       actionsPadding: Dimens.dialogActionsPadding,
       actions: [
         TextButton(