ML-166 Fixed golden tests run on CI (#168)

* stub iap for goldens workflow

* typo

* Updated goldens

* don't push iap stub when updating goldens

* Update pubspec.yaml

* try explicit fonts

* Updated goldens

* set explicit font weights

* disable font smoothing

* run goldens on macos

* typo

* removed defaults from goldens workflow

* run pr check on macos-14

* removed smoothening reset

* Delete run_golden_tests.yml

* deleted fonts folder

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

.github/workflows/pr_check.yml

@@ -14,7 +14,7 @@ on:
 jobs:
   analyze-and-test:
     name: Analyze & test
-    runs-on: macos-latest
+    runs-on: macos-14
     timeout-minutes: 10
     steps:
       - uses: 8BitJonny/gh-get-current-pr@2.2.0
@@ -54,7 +54,9 @@ jobs:
         run: flutter analyze lib --fatal-infos
 
       - name: Run tests
-        run: flutter test --dart-define cameraStubImage=assets/camera_stub_image.jpg
+        run: |
+          defaults -currentHost write -g AppleFontSmoothing -int 0
+          flutter test --dart-define cameraStubImage=assets/camera_stub_image.jpg
 
       - name: Analyze project source with stub
         if: steps.override-iap.conclusion != 'success'

.github/workflows/run_golden_tests.yml

@@ -1,62 +0,0 @@
-# This workflow uses actions that are not certified by GitHub.
-# They are provided by a third-party and are governed by
-# separate terms of service, privacy policy, and support
-# documentation.
-
-name: Run golden tests
-
-on:
-  workflow_dispatch:
-    inputs:
-      update-goldens:
-        type: boolean
-        description: Update goldens
-        default: false
-
-jobs:
-  run-golden-tests:
-    name: Run golden tests
-    timeout-minutes: 5
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          submodules: recursive
-
-      - uses: subosito/flutter-action@v2
-        with:
-          channel: "stable"
-          flutter-version: "3.13.9"
-
-      - name: Prepare app
-        run: |
-          flutter --version
-          flutter pub get
-          flutter pub run intl_utils:generate
-
-      - name: Run tests
-        env:
-          UPDATE_GOLDENS: ${{inputs.update-goldens && '--update-goldens' || '' }}ƒ
-        run: |
-          goldens=$(find ./test -name "*_golden_test.dart" -print)
-          for f in $goldens; do
-            flutter test "$f"\
-                --dart-define cameraStubImage=assets/camera_stub_image.jpg \
-                $UPDATE_GOLDENS
-          done
-
-      - name: Commit changes
-        if: ${{ inputs.update-goldens }}
-        run: |
-          git config --local user.email "github-actions[bot]@users.noreply.github.com"
-          git config --local user.name "github-actions[bot]"
-          git add -A
-          git commit -m "Updated goldens"
-
-      - name: Push to main
-        if: ${{ inputs.update-goldens }}
-        uses: CasperWA/push-protected@v2
-        with:
-          token: ${{ secrets.PUSH_TO_MAIN_TOKEN }}
-          branch: ${{ github.ref_name }}
-          unprotect_reviews: true

update_goldens.sh

@@ -0,0 +1,6 @@
+defaults -currentHost write -g AppleFontSmoothing -int 0
+goldens=$(find ./test -name "*_golden_test.dart" -print)
+for f in $goldens; do
+    flutter test "$f" --dart-define cameraStubImage=assets/camera_stub_image.jpg --update-goldens
+done
+defaults -currentHost write -g AppleFontSmoothing -int 3