From f611434d51bdc40b105d6afa60e0cf0b5896c5f3 Mon Sep 17 00:00:00 2001
From: Vadim <vadim.turko@gmail.com>
Date: Thu, 22 Jun 2023 22:05:55 +0200
Subject: [PATCH] `migrateOldKeys()` tests

---
 lib/data/shared_prefs_service.dart       |  5 +-
 test/data/shared_prefs_service_test.dart | 62 ++++++++++++++++++++++++
 2 files changed, 65 insertions(+), 2 deletions(-)

diff --git a/lib/data/shared_prefs_service.dart b/lib/data/shared_prefs_service.dart
index 56207ea..be6d9d3 100644
--- a/lib/data/shared_prefs_service.dart
+++ b/lib/data/shared_prefs_service.dart
@@ -30,10 +30,11 @@ class UserPreferencesService {
   final SharedPreferences _sharedPreferences;
 
   UserPreferencesService(this._sharedPreferences) {
-    _migrateOldKeys();
+    migrateOldKeys();
   }
 
-  Future<void> _migrateOldKeys() async {
+  @visibleForTesting
+  Future<void> migrateOldKeys() async {
     final legacyIsoIndex = _sharedPreferences.getInt("curIsoIndex");
     if (legacyIsoIndex != null) {
       iso = IsoValue.values[legacyIsoIndex];
diff --git a/test/data/shared_prefs_service_test.dart b/test/data/shared_prefs_service_test.dart
index e2b1088..c0401e5 100644
--- a/test/data/shared_prefs_service_test.dart
+++ b/test/data/shared_prefs_service_test.dart
@@ -22,6 +22,68 @@ void main() {
     service = UserPreferencesService(sharedPreferences);
   });
 
+  group('migrateOldKeys()', () {
+    test('no legacy keys', () async {
+      when(() => sharedPreferences.getInt("curIsoIndex")).thenReturn(null);
+      when(() => sharedPreferences.getInt("curndIndex")).thenReturn(null);
+      when(() => sharedPreferences.getDouble("cameraCalibr")).thenReturn(null);
+      when(() => sharedPreferences.getDouble("sensorCalibr")).thenReturn(null);
+      when(() => sharedPreferences.getBool("vibrate")).thenReturn(null);
+
+      when(() => sharedPreferences.remove("curIsoIndex")).thenAnswer((_) async => true);
+      when(() => sharedPreferences.remove("curndIndex")).thenAnswer((_) async => true);
+      when(() => sharedPreferences.remove("cameraCalibr")).thenAnswer((_) async => true);
+      when(() => sharedPreferences.remove("sensorCalibr")).thenAnswer((_) async => true);
+      when(() => sharedPreferences.remove("vibrate")).thenAnswer((_) async => true);
+
+      await service.migrateOldKeys();
+
+      verifyNever(() => sharedPreferences.remove("curIsoIndex"));
+      verifyNever(() => sharedPreferences.remove("curndIndex"));
+      verifyNever(() => sharedPreferences.remove("cameraCalibr"));
+      verifyNever(() => sharedPreferences.remove("sensorCalibr"));
+      verifyNever(() => sharedPreferences.remove("vibrate"));
+    });
+
+    test('migrate all keys', () async {
+      when(() => sharedPreferences.getInt("curIsoIndex")).thenReturn(1);
+      when(() => sharedPreferences.getInt("curndIndex")).thenReturn(0);
+      when(() => sharedPreferences.getDouble("cameraCalibr")).thenReturn(1.0);
+      when(() => sharedPreferences.getDouble("sensorCalibr")).thenReturn(-1.0);
+      when(() => sharedPreferences.getBool("vibrate")).thenReturn(false);
+
+      when(
+        () => sharedPreferences.setInt(UserPreferencesService.isoKey, IsoValue.values[1].value),
+      ).thenAnswer((_) => Future.value(true));
+      when(
+        () => sharedPreferences.setInt(UserPreferencesService.ndFilterKey, NdValue.values[0].value),
+      ).thenAnswer((_) => Future.value(true));
+      when(
+        () => sharedPreferences.setDouble(UserPreferencesService.cameraEvCalibrationKey, 1.0),
+      ).thenAnswer((_) => Future.value(true));
+      when(
+        () => sharedPreferences.setDouble(UserPreferencesService.lightSensorEvCalibrationKey, -1.0),
+      ).thenAnswer((_) => Future.value(true));
+      when(
+        () => sharedPreferences.setBool(UserPreferencesService.hapticsKey, false),
+      ).thenAnswer((_) => Future.value(true));
+
+      when(() => sharedPreferences.remove("curIsoIndex")).thenAnswer((_) async => true);
+      when(() => sharedPreferences.remove("curndIndex")).thenAnswer((_) async => true);
+      when(() => sharedPreferences.remove("cameraCalibr")).thenAnswer((_) async => true);
+      when(() => sharedPreferences.remove("sensorCalibr")).thenAnswer((_) async => true);
+      when(() => sharedPreferences.remove("vibrate")).thenAnswer((_) async => true);
+
+      await service.migrateOldKeys();
+
+      verify(() => sharedPreferences.remove("curIsoIndex")).called(1);
+      verify(() => sharedPreferences.remove("curndIndex")).called(1);
+      verify(() => sharedPreferences.remove("cameraCalibr")).called(1);
+      verify(() => sharedPreferences.remove("sensorCalibr")).called(1);
+      verify(() => sharedPreferences.remove("vibrate")).called(1);
+    });
+  });
+
   group('iso', () {
     test('get default', () {
       when(() => sharedPreferences.getInt(UserPreferencesService.isoKey)).thenReturn(null);