Compare commits

..

No commits in common. "75c504352a2e0afb26906f5d9bcc65668d1a8f86" and "bed4535910cd2302b7b6bf442a6dd252c6553b67" have entirely different histories.

2 changed files with 17 additions and 13 deletions

View file

@ -14,10 +14,6 @@ on:
description: "Version" description: "Version"
required: true required: true
type: string type: string
release-notes:
description: "Release notes"
required: true
type: string
env: env:
BUILD_ARGS: --release --flavor prod --dart-define cameraPreviewAspectRatio=240/320 -t lib/main_prod.dart BUILD_ARGS: --release --flavor prod --dart-define cameraPreviewAspectRatio=240/320 -t lib/main_prod.dart
@ -167,11 +163,20 @@ jobs:
unzip app-prod-release.aab unzip app-prod-release.aab
(cd base/lib && zip -r "$OLDPWD/merged_native_libs.zip" .) (cd base/lib && zip -r "$OLDPWD/merged_native_libs.zip" .)
- name: Upload merged native libs to artifacts - name: Zip app bundle and merged_native_libs
run: zip m3_lightmeter_release.zip app-prod-release.aab merged_native_libs.zip
- name: Upload merged_native_libs.zip to artifacts
uses: actions/upload-artifact@v3 uses: actions/upload-artifact@v3
with: with:
name: merged_native_libs name: m3_lightmeter_release
path: merged_native_libs.zip path: m3_lightmeter_release.zip
# TODO: this should be moved to `create-google-play-release` step when it is implemented
- name: Delete no longer used app bundle artifact
uses: geekyeggo/delete-artifact@v2
with:
name: m3_lightmeter_bundle
# TODO: Automate Google Play releases creation # TODO: Automate Google Play releases creation
create-google-play-release: create-google-play-release:
@ -188,14 +193,15 @@ jobs:
merged_native_libs merged_native_libs
- name: Create Google Play release - name: Create Google Play release
uses: r0adkll/upload-google-play@v1.1.1 uses: r0adkll/upload-google-play@v1
with: with:
serviceAccountJsonPlainText: ${{ secrets.GH_ACTIONS_SERVICE_ACCOUNT_JSON }} serviceAccountJsonPlainText: #TODO:
packageName: com.vodemn.lightmeter packageName: com.vodemn.lightmeter
releaseFiles: app-prod-release.aab releaseFiles: app-prod-release.aab
track: production track: production
status: draft status: inProgress
userFraction: 1.0 userFraction: 1.0
whatsNewDirectory: #TODO:
debugSymbols: merged_native_libs.zip debugSymbols: merged_native_libs.zip
- name: Delete no longer used app bundle & merged native libs artifacts - name: Delete no longer used app bundle & merged native libs artifacts

View file

@ -28,9 +28,7 @@ class _CameraHistogramState extends State<CameraHistogram> {
@override @override
void dispose() { void dispose() {
/// There is no need to stop image stream here, widget.controller.stopImageStream();
/// because this widget will be disposed when CameraController is disposed
/// widget.controller.stopImageStream();
super.dispose(); super.dispose();
} }