Compare commits

..

4 commits

Author SHA1 Message Date
Vadim
75c504352a Update create_release.yml 2023-08-08 15:21:56 +02:00
Vadim
8107a6a3bf Delete all artefacts after GP release 2023-08-08 11:53:51 +02:00
Vadim
7db3c6bded Merge remote-tracking branch 'origin' into feature/ML-61 2023-08-08 11:47:55 +02:00
Vadim
d91441bac9
ML-95 Live histogram (#100)
* Removed redundant `stopImageStream()`
2023-08-08 11:46:43 +02:00
2 changed files with 13 additions and 17 deletions

View file

@ -14,6 +14,10 @@ on:
description: "Version"
required: true
type: string
release-notes:
description: "Release notes"
required: true
type: string
env:
BUILD_ARGS: --release --flavor prod --dart-define cameraPreviewAspectRatio=240/320 -t lib/main_prod.dart
@ -163,20 +167,11 @@ jobs:
unzip app-prod-release.aab
(cd base/lib && zip -r "$OLDPWD/merged_native_libs.zip" .)
- name: Zip app bundle and merged_native_libs
run: zip m3_lightmeter_release.zip app-prod-release.aab merged_native_libs.zip
- name: Upload merged_native_libs.zip to artifacts
- name: Upload merged native libs to artifacts
uses: actions/upload-artifact@v3
with:
name: m3_lightmeter_release
path: m3_lightmeter_release.zip
# TODO: this should be moved to `create-google-play-release` step when it is implemented
- name: Delete no longer used app bundle artifact
uses: geekyeggo/delete-artifact@v2
with:
name: m3_lightmeter_bundle
name: merged_native_libs
path: merged_native_libs.zip
# TODO: Automate Google Play releases creation
create-google-play-release:
@ -193,15 +188,14 @@ jobs:
merged_native_libs
- name: Create Google Play release
uses: r0adkll/upload-google-play@v1
uses: r0adkll/upload-google-play@v1.1.1
with:
serviceAccountJsonPlainText: #TODO:
serviceAccountJsonPlainText: ${{ secrets.GH_ACTIONS_SERVICE_ACCOUNT_JSON }}
packageName: com.vodemn.lightmeter
releaseFiles: app-prod-release.aab
track: production
status: inProgress
status: draft
userFraction: 1.0
whatsNewDirectory: #TODO:
debugSymbols: merged_native_libs.zip
- name: Delete no longer used app bundle & merged native libs artifacts

View file

@ -28,7 +28,9 @@ class _CameraHistogramState extends State<CameraHistogram> {
@override
void dispose() {
widget.controller.stopImageStream();
/// There is no need to stop image stream here,
/// because this widget will be disposed when CameraController is disposed
/// widget.controller.stopImageStream();
super.dispose();
}