Compare commits

..

No commits in common. "cabc50d2aab3e7d863c650bba86bfffe27b79cad" and "e391056e2957bab7a665c64c1d930637a3ba6e90" have entirely different histories.

7 changed files with 15 additions and 48 deletions

View file

@ -16,27 +16,17 @@ on:
- dev - dev
- prod - prod
default: 'dev' default: 'dev'
include-iap:
type: boolean
description: Include IAP package
default: false # TODO(@vodemn) when Google fixes their api
jobs: jobs:
build: build:
name: Build .apk name: Build .apk
runs-on: macos-11 runs-on: macos-11
timeout-minutes: 15 timeout-minutes: 15
steps: steps:
- name: Connect private iap package - uses: webfactory/ssh-agent@v0.8.0
uses: webfactory/ssh-agent@v0.8.0
if: ${{ inputs.include-iap }}
with: with:
ssh-private-key: ${{ secrets.M3_LIGHTMETER_IAP_KEY }} ssh-private-key: ${{ secrets.M3_LIGHTMETER_IAP_KEY }}
- name: Override iap package with stub
if: ${{ !inputs.include-iap }}
run: |
echo "\ndependecies_override:\n m3_lightmeter_iap:\n path: iap" >> pubspec.yaml
- uses: actions/checkout@v3 - uses: actions/checkout@v3
with: with:

View file

@ -31,10 +31,6 @@ on:
type: boolean type: boolean
description: Create Google Play release description: Create Google Play release
default: true default: true
include-iap:
type: boolean
description: Include IAP package
default: false # TODO(@vodemn) when Google fixes their api
env: env:
BUILD_ARGS: --release --flavor prod --dart-define cameraPreviewAspectRatio=240/320 -t lib/main_prod.dart BUILD_ARGS: --release --flavor prod --dart-define cameraPreviewAspectRatio=240/320 -t lib/main_prod.dart
@ -42,21 +38,14 @@ env:
jobs: jobs:
build: build:
name: Build .apk & .aab name: Build .apk & .aab
if: ${{ inputs.github-release || inputs.google-play-release }} if: ${{ inputs.github-release }} || ${{ inputs.google-play-release }}
runs-on: macos-11 runs-on: macos-11
timeout-minutes: 30 timeout-minutes: 30
steps: steps:
- name: Connect private iap package - uses: webfactory/ssh-agent@v0.8.0
uses: webfactory/ssh-agent@v0.8.0
if: ${{ inputs.include-iap }}
with: with:
ssh-private-key: ${{ secrets.M3_LIGHTMETER_IAP_KEY }} ssh-private-key: ${{ secrets.M3_LIGHTMETER_IAP_KEY }}
- name: Override iap package with stub
if: ${{ !inputs.include-iap }}
run: |
echo "\ndependecies_override:\n m3_lightmeter_iap:\n path: iap" >> pubspec.yaml
- uses: actions/checkout@v3 - uses: actions/checkout@v3
with: with:
submodules: recursive submodules: recursive

View file

@ -11,27 +11,20 @@ on:
pull_request: pull_request:
branches: ["main"] branches: ["main"]
env:
# Stub iap package if this worlflow is running from the PR from a fork
STUB_IAP: ${{ github.event.pull_request.head.repo.full_name != github.repository }}
jobs: jobs:
analyze_and_test: analyze_and_test:
name: Analyze & test name: Analyze & test
runs-on: macos-11 runs-on: macos-11
timeout-minutes: 10 timeout-minutes: 10
steps: steps:
- name: Connect private iap package - uses: shaunco/ssh-agent@git-repo-mapping
uses: webfactory/ssh-agent@v0.8.0
if: !env.STUB_IAP
with: with:
ssh-private-key: ${{ secrets.M3_LIGHTMETER_IAP_KEY }} ssh-private-key: |
${{ secrets.M3_LIGHTMETER_IAP_KEY }}
- name: Override iap package with stub repo-mappings: |
if: env.STUB_IAP github.com/vodemn/m3_lightmeter_iap
run: |
echo "\ndependecies_override:\n m3_lightmeter_iap:\n path: iap" >> pubspec.yaml
- uses: actions/checkout@v3 - uses: actions/checkout@v3
with: with:
submodules: recursive submodules: recursive
@ -39,7 +32,7 @@ jobs:
- uses: subosito/flutter-action@v2 - uses: subosito/flutter-action@v2
with: with:
channel: "stable" channel: "stable"
flutter-version: "3.10.0" flutter-version: '3.10.0'
- name: Prepare flutter project - name: Prepare flutter project
run: | run: |
@ -51,4 +44,4 @@ jobs:
run: flutter analyze lib --fatal-infos run: flutter analyze lib --fatal-infos
- name: Run tests - name: Run tests
run: flutter test run: flutter test

View file

@ -135,7 +135,7 @@ class CameraContainer extends StatelessWidget {
} }
double _cameraPreviewHeight(BuildContext context) { double _cameraPreviewHeight(BuildContext context) {
return ((MediaQuery.sizeOf(context).width - Dimens.grid8 - 2 * Dimens.paddingM) / 2) / return ((MediaQuery.of(context).size.width - Dimens.grid8 - 2 * Dimens.paddingM) / 2) /
PlatformConfig.cameraPreviewAspectRatio; PlatformConfig.cameraPreviewAspectRatio;
} }
} }

View file

@ -39,7 +39,7 @@ class ReadingsContainer extends StatelessWidget {
children: [ children: [
if (UserPreferencesProvider.meteringScreenFeatureOf( if (UserPreferencesProvider.meteringScreenFeatureOf(
context, context,
MeteringScreenLayoutFeature.equipmentProfiles, MeteringScreenLayoutFeature.extremeExposurePairs,
)) ...[ )) ...[
const _EquipmentProfilePicker(), const _EquipmentProfilePicker(),
const _InnerPadding(), const _InnerPadding(),

View file

@ -36,7 +36,6 @@ class _MeteringScreenLayoutFeaturesDialogState extends State<MeteringScreenLayou
_featureListTile(MeteringScreenLayoutFeature.equipmentProfiles), _featureListTile(MeteringScreenLayoutFeature.equipmentProfiles),
_featureListTile(MeteringScreenLayoutFeature.extremeExposurePairs), _featureListTile(MeteringScreenLayoutFeature.extremeExposurePairs),
_featureListTile(MeteringScreenLayoutFeature.filmPicker), _featureListTile(MeteringScreenLayoutFeature.filmPicker),
_featureListTile(MeteringScreenLayoutFeature.histogram),
], ],
), ),
), ),

View file

@ -57,7 +57,3 @@ flutter:
flutter_intl: flutter_intl:
enabled: true enabled: true
dependecies_override:
m3_lightmeter_iap:
path: iap